-
Notifications
You must be signed in to change notification settings - Fork 741
Create add-unanswered-to-project.yml #12752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding a workflow automation to dynamically add unanswered PRs and issues to project view
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12752
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit fcfedba with merge base afdbb85 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Is it possible to test the workflow before landing it in the repo? If so, do you have any results you can attach to the PR? |
| } | ||
|
|
||
| try { | ||
| // Add open issues (not PRs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it's only adding issues. Can we add both PRs and issues?
| @@ -0,0 +1,76 @@ | |||
| name: Add Unanswered PRs and Issues to PyTorch Org Project 136 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about renaming to "Add External PRs and Issues...", since we're not filtering by unanswered yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, considering the current queries look at just open PRs and Issues. I could change it to "Add Open External Contributor PRs and Issues to PyTorch Org Project 136"
|
Would it be possible to add the author filter in the workflow, as well? Or is it easier to apply as a view? |
| } | ||
| } | ||
|
|
||
| // Add open, non-draft PRs with NO approved reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GregoryComer this block covers PRs as well
1) Changes title from "Add Unanswered PRs and Issues to PyTorch Org Project 136" to "Add Open External Contributor PRs and Issues to PyTorch Org Project 136" 2) Changed constraint to add PRs from adding approved PRs as well
Adding a workflow automation to dynamically add unanswered PRs and issues to project view (https://github.com/orgs/pytorch/projects/133)
Adding a workflow automation to dynamically add unanswered PRs and issues to project view (https://github.com/orgs/pytorch/projects/136)